Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws_server can deadlock #752

Closed
Niederb opened this issue May 20, 2022 · 1 comment · Fixed by #766
Closed

ws_server can deadlock #752

Niederb opened this issue May 20, 2022 · 1 comment · Fixed by #766
Assignees
Labels
F2-bug Something isn't working

Comments

@Niederb
Copy link
Contributor

Niederb commented May 20, 2022

It happens when there are many incoming transactions/Websockets, such as during the benchmark.
This can happen due to the lock over the connections in ws_server.rs.
If the lock is not release properly then new connections cannot be accepted due to the lock being needed in accept_connection(...)

The lock is not being released as on_ready(..) is not returning. Inside on_ready(..) it seems to be read_or_initialize_websocket(..) that is blocking. This is where I stopped digging for now.

@Niederb Niederb added the F2-bug Something isn't working label May 20, 2022
@gaudenzkessler gaudenzkessler assigned Niederb and murerfel and unassigned Niederb May 24, 2022
@Niederb
Copy link
Contributor Author

Niederb commented May 24, 2022

I also saw now that the number of threads is "stuck" at 17 after the deadlock whereas before it seems to be changing between 17 and 20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F2-bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants