Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: 6.5.0 breaks for organization-roles API endpoint users on GHES <3.13 #2539

Open
1 task done
isaacsanders opened this issue Jan 17, 2025 · 2 comments
Open
1 task done
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@isaacsanders
Copy link

Expected Behavior

The breaking change should be a breaking semver change

Actual Behavior

It’s a minor version causing a breaking change

Terraform Version

1.5.5

Affected Resource(s)

Github_organization_security_manager

Terraform Configuration Files

Steps to Reproduce

No response

Debug Output

Panic Output

Code of Conduct

  • I agree to follow this project's Code of Conduct
@isaacsanders isaacsanders added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Jan 17, 2025
@parente
Copy link

parente commented Jan 27, 2025

We spotted this regression in our Terraform plans when the 6.5.0 provider tries to read existing github_organization_security_manager resources.

Using v6.4.0 of the provider, running a plan a fine-grained access token having Organization Member read/write permission worked successfully.

Using v6.5.0, we receive an error:

Error: GET https://api.github.com/orgs/xxx/organization-roles: 403 Resource not accessible by integration []

@gk-drw
Copy link

gk-drw commented Jan 31, 2025

This change makes the minimum supported GHES version for the provider to be 3.14 since it relies on https://docs.github.com/en/[email protected]/rest/orgs/organization-roles

These endpoints are used in #2533 and are returning 404 on GHES versions < 3.14

Since some of these GHES versions are still officially supported by GitHub, it would make sense to either

  • revert the above pull request, or
  • rework the above pull request to be able to handle both older and newer API approaches

Do you have any precedent on how to deal with this type of API bifurcation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
None yet
Development

No branches or pull requests

3 participants