Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#loadWithRequiredMaps should also check by timestamp #48

Closed
marianopeck opened this issue May 13, 2020 · 1 comment
Closed

#loadWithRequiredMaps should also check by timestamp #48

marianopeck opened this issue May 13, 2020 · 1 comment
Assignees
Labels
importing Issues related with importing from Tonel format
Milestone

Comments

@marianopeck
Copy link
Collaborator

Currently, #loadWithRequiredMaps is only looking by version name:

 (EmConfigurationMap editionsFor: self name)
		detect: [:one | one versionName = self versionName]
		ifNone: [

However, its quite common and likely for versions to be renamed. Therefore, the lookup should be:

Look for versions with exact timestamp...if only one, pick that one, regardless of version name. If more than one, try to detect if there is one with same version name as specified.

@marianopeck marianopeck added this to the 1.1 milestone May 13, 2020
@eMaringolo
Copy link
Collaborator

Fixed by b8339fb

@eMaringolo eMaringolo added the importing Issues related with importing from Tonel format label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
importing Issues related with importing from Tonel format
Projects
None yet
Development

No branches or pull requests

2 participants