Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong equality comparison in TonelReaderClassDefinition #106

Closed
eMaringolo opened this issue Mar 30, 2022 · 0 comments
Closed

Wrong equality comparison in TonelReaderClassDefinition #106

eMaringolo opened this issue Mar 30, 2022 · 0 comments
Assignees
@eMaringolo
Labels
bug Something isn't working

Comments

@eMaringolo
Copy link
Collaborator

The method TonelReaderClassDefinition>#= is assuming the parameter is going to be another class definition or nil, which is wrong, since it could be the case that it is a TonelReaderClassExtensionDefinition.

The method should be modified to consider such a case, and also implement an equality method in TonelReaderClassExtensionDefinition in case the receiver and arguments are inverted when comparing them.
@eMaringolo eMaringolo added the bug Something isn't working label Mar 30, 2022
@eMaringolo eMaringolo self-assigned this Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eMaringolo eMaringolo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eMaringolo