fix: reduced log flooding when collector is not rdy #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussed: We want to use |
|
Why is AWS not listed for disabling individual instrumentations? |
kirrg001
force-pushed
the
fix/kafkaissue
branch
from
be31a91 to
7a340a5
Compare
|
For the record, we discussed this offline. We can only disable all of the AWS v3 instrumentations at once currently, more or less. The available strings for disabling would be:
We agreed to not change this in the scope of this PR. We will consider refactoring the mechanism for disabling individual instrumentation plug-ins with the next major update (3.0.0). |
basti1302
approved these changes
Aug 24, 2023
packages/core/src/tracing/instrumentation/cloud/aws-sdk/v2/lambda.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #849
IMO the underlying problem of #849 is that the collector cannot connect to the Agent but the process already receives traffic. And then we would flood the log file with the warning.