Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stack.slice not a function #828

Merged
merged 1 commit into from
Jul 21, 2023
Merged

fix: stack.slice not a function #828

merged 1 commit into from
Jul 21, 2023

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Jul 21, 2023 •
edited
Loading

Reported by customer.

@kirrg001 kirrg001 requested a review from a team as a code owner July 21, 2023 07:50
basti1302
basti1302 approved these changes Jul 21, 2023
View reviewed changes
packages/core/src/util/stackTrace.js Show resolved Hide resolved
packages/core/src/util/stackTrace.js Show resolved Hide resolved
aryamohanan
aryamohanan reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@aryamohanan aryamohanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me 👍

@kirrg001 kirrg001 merged commit 827a722 into main Jul 21, 2023
@kirrg001 kirrg001 deleted the fix/stacksplice branch July 21, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basti1302 basti1302 basti1302 approved these changes

@aryamohanan aryamohanan aryamohanan left review comments

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirrg001 @basti1302 @aryamohanan