fix(metrics): do not report metrics from worker threads #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basti1302
force-pushed
the
worker-thread-fix
branch
from
0da40e0 to
64dbc9e
Compare
basti1302
commented
Mar 29, 2022
| @@ -37,6 +46,7 @@ exports.init = function init(config, isReInit) { | |||
| // we create later on. | |||
| parentLogger = bunyan.createLogger({ | |||
| name: '@instana/collector', | |||
| thread: threadId, | |||
There was a problem hiding this comment.
Adding the thread ID to the log object is not strictly necessary but we have the PID in there, too, and I think it might be pretty helpful when trouble shooting scenarios involving worker threads in the future.
basti1302
force-pushed
the
worker-thread-fix
branch
from
64dbc9e to
0ae3cec
Compare
kirrg001
approved these changes
Mar 30, 2022
When instrumented via NODE_OPTIONS="--require ..." (which is inherited by worker threads), each worker thread will announce independently and act like the main thread. This can cause issues, in particular if the worker thread is started from a dependency in node_ module and it identifies a different package.json as its main package.json, hence reporting a different application name etc. To prevent this, we disable sending metrics and snapshot data from worker threads for now. fixes #500 refs 88823
basti1302
force-pushed
the
worker-thread-fix
branch
from
0ae3cec to
4fb5631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When instrumented via NODE_OPTIONS="--require ..." (which is inherited by
worker threads), each worker thread will announce independently and act like
the main thread. This can cause issues, in particular if the worker thread is
started from a dependency in node_ module and it identifies a different
package.json as its main package.json, hence reporting a different application
name etc.
To prevent this, we disable sending metrics and snapshot data from
worker threads for now.
fixes #500
refs 88823