Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed disableAutomaticTracing legacy config #432

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Dec 9, 2021

refs 80206

I found this config. It looks legacy to me. Need to update the docs for all config changes before releasing v2

https://www.instana.com/docs/ecosystem/node-js/configuration/

Alternativ: Deprecated the config first, but somehow this config already looks deprecated. Maybe the docs were not updated to be clear?

@kirrg001 kirrg001 force-pushed the remove/automaticlegacyconfig branch from 3404e4a to 802e1c3 Compare December 9, 2021 10:25
@kirrg001 kirrg001 requested a review from a team December 9, 2021 10:42
@kirrg001 kirrg001 force-pushed the remove/automaticlegacyconfig branch from 802e1c3 to aac27c6 Compare December 9, 2021 17:00
Copy link
Contributor

@basti1302 basti1302 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kirrg001 kirrg001 merged commit 360259b into v2 Dec 13, 2021
@kirrg001 kirrg001 deleted the remove/automaticlegacyconfig branch December 13, 2021 12:21
basti1302 pushed a commit that referenced this pull request Jan 10, 2022
basti1302 pushed a commit that referenced this pull request Feb 1, 2022
kirrg001 added a commit that referenced this pull request Feb 7, 2022
kirrg001 added a commit that referenced this pull request Feb 10, 2022
kirrg001 added a commit that referenced this pull request Feb 10, 2022
refs 80206

BREAKING CHANGE: Removed "disableAutomaticTracing" config option.
                 Use `instana({ automaticTracingEnabled: Boolean })`.

Co-authored-by: kirrg001 <[email protected]>
kirrg001 added a commit that referenced this pull request Mar 8, 2022
refs 80206

BREAKING CHANGE: Removed "disableAutomaticTracing" config option.
                 Use `instana({ automaticTracingEnabled: Boolean })`.

Co-authored-by: kirrg001 <[email protected]>
kirrg001 added a commit that referenced this pull request Mar 9, 2022
refs 80206

BREAKING CHANGE: Removed "disableAutomaticTracing" config option.
                 Use `instana({ automaticTracingEnabled: Boolean })`.
basti1302 pushed a commit that referenced this pull request Mar 9, 2022
refs 80206

BREAKING CHANGE: Removed "disableAutomaticTracing" config option.
                 Use `instana({ automaticTracingEnabled: Boolean })`.
basti1302 pushed a commit that referenced this pull request Mar 10, 2022
refs 80206

BREAKING CHANGE: Removed "disableAutomaticTracing" config option.
                 Use `instana({ automaticTracingEnabled: Boolean })`.
kirrg001 added a commit that referenced this pull request Mar 21, 2022
refs 80206

BREAKING CHANGE: Removed "disableAutomaticTracing" config option.
                 Use `instana({ automaticTracingEnabled: Boolean })`.
kirrg001 added a commit that referenced this pull request Apr 1, 2022
refs 80206

BREAKING CHANGE: Removed "disableAutomaticTracing" config option.
                 Use `instana({ automaticTracingEnabled: Boolean })`.
kirrg001 added a commit that referenced this pull request Apr 1, 2022
refs 80206

BREAKING CHANGE: Removed "disableAutomaticTracing" config option.
                 Use `instana({ automaticTracingEnabled: Boolean })`.
kirrg001 added a commit that referenced this pull request Apr 1, 2022
refs 80206

BREAKING CHANGE: Removed "disableAutomaticTracing" config option.
                 Use `instana({ automaticTracingEnabled: Boolean })`.
kirrg001 added a commit that referenced this pull request Apr 1, 2022
refs 80206

BREAKING CHANGE: Removed "disableAutomaticTracing" config option.
                 Use `instana({ automaticTracingEnabled: Boolean })`.
kirrg001 added a commit that referenced this pull request Apr 4, 2022
refs 80206

BREAKING CHANGE: Removed "disableAutomaticTracing" config option.
                 Use `instana({ automaticTracingEnabled: Boolean })`.
kirrg001 added a commit that referenced this pull request Apr 4, 2022
refs 80206

BREAKING CHANGE: Removed "disableAutomaticTracing" config option.
                 Use `instana({ automaticTracingEnabled: Boolean })`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants