-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removed disableAutomaticTracing legacy config #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3404e4a
to
802e1c3
Compare
802e1c3
to
aac27c6
Compare
basti1302
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
basti1302
pushed a commit
that referenced
this pull request
Jan 10, 2022
refs 80206 Co-authored-by: kirrg001 <[email protected]>
basti1302
pushed a commit
that referenced
this pull request
Feb 1, 2022
refs 80206 Co-authored-by: kirrg001 <[email protected]>
kirrg001
added a commit
that referenced
this pull request
Feb 7, 2022
refs 80206 Co-authored-by: kirrg001 <[email protected]>
kirrg001
added a commit
that referenced
this pull request
Feb 10, 2022
refs 80206 Co-authored-by: kirrg001 <[email protected]>
kirrg001
added a commit
that referenced
this pull request
Feb 10, 2022
refs 80206 BREAKING CHANGE: Removed "disableAutomaticTracing" config option. Use `instana({ automaticTracingEnabled: Boolean })`. Co-authored-by: kirrg001 <[email protected]>
kirrg001
added a commit
that referenced
this pull request
Mar 8, 2022
refs 80206 BREAKING CHANGE: Removed "disableAutomaticTracing" config option. Use `instana({ automaticTracingEnabled: Boolean })`. Co-authored-by: kirrg001 <[email protected]>
kirrg001
added a commit
that referenced
this pull request
Mar 9, 2022
refs 80206 BREAKING CHANGE: Removed "disableAutomaticTracing" config option. Use `instana({ automaticTracingEnabled: Boolean })`.
basti1302
pushed a commit
that referenced
this pull request
Mar 9, 2022
refs 80206 BREAKING CHANGE: Removed "disableAutomaticTracing" config option. Use `instana({ automaticTracingEnabled: Boolean })`.
basti1302
pushed a commit
that referenced
this pull request
Mar 10, 2022
refs 80206 BREAKING CHANGE: Removed "disableAutomaticTracing" config option. Use `instana({ automaticTracingEnabled: Boolean })`.
kirrg001
added a commit
that referenced
this pull request
Mar 21, 2022
refs 80206 BREAKING CHANGE: Removed "disableAutomaticTracing" config option. Use `instana({ automaticTracingEnabled: Boolean })`.
kirrg001
added a commit
that referenced
this pull request
Apr 1, 2022
refs 80206 BREAKING CHANGE: Removed "disableAutomaticTracing" config option. Use `instana({ automaticTracingEnabled: Boolean })`.
kirrg001
added a commit
that referenced
this pull request
Apr 1, 2022
refs 80206 BREAKING CHANGE: Removed "disableAutomaticTracing" config option. Use `instana({ automaticTracingEnabled: Boolean })`.
kirrg001
added a commit
that referenced
this pull request
Apr 1, 2022
refs 80206 BREAKING CHANGE: Removed "disableAutomaticTracing" config option. Use `instana({ automaticTracingEnabled: Boolean })`.
kirrg001
added a commit
that referenced
this pull request
Apr 1, 2022
refs 80206 BREAKING CHANGE: Removed "disableAutomaticTracing" config option. Use `instana({ automaticTracingEnabled: Boolean })`.
kirrg001
added a commit
that referenced
this pull request
Apr 4, 2022
refs 80206 BREAKING CHANGE: Removed "disableAutomaticTracing" config option. Use `instana({ automaticTracingEnabled: Boolean })`.
kirrg001
added a commit
that referenced
this pull request
Apr 4, 2022
refs 80206 BREAKING CHANGE: Removed "disableAutomaticTracing" config option. Use `instana({ automaticTracingEnabled: Boolean })`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs 80206
I found this config. It looks legacy to me. Need to update the docs for all config changes before releasing v2
https://www.instana.com/docs/ecosystem/node-js/configuration/
Alternativ: Deprecated the config first, but somehow this config already looks deprecated. Maybe the docs were not updated to be clear?