Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for graphql-ws v6 #1516

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

instanacd
Copy link
Contributor

@instanacd instanacd commented Jan 15, 2025

@instanacd instanacd requested a review from a team as a code owner January 15, 2025 18:13
@aryamohanan aryamohanan self-assigned this Jan 16, 2025
@@ -70,7 +70,7 @@ startServer();

const httpServer = http.createServer(app);

const { useServer } = require('graphql-ws/lib/use/ws');
const { useServer } = require('graphql-ws/use/ws');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The /lib/ part from imports has been removed, for example graphql-ws/lib/use/ws becomes graphql-ws/use/ws
see https://github.com/enisdenjo/graphql-ws/releases

@aryamohanan aryamohanan force-pushed the currency-bot-major-graphqlws branch from 6b4d96b to a8ed09a Compare January 16, 2025 06:13
@aryamohanan aryamohanan changed the title [Currency Bot] Bumped graphql-ws from 5.16.2 to 6.0.0 feat: added support for graphql-ws v6 Jan 16, 2025
Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ws is already on v8

ws v7 has been deprecated. Please upgrade and use v8.

Copy link
Contributor

@abhilash-sivan abhilash-sivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aryamohanan aryamohanan merged commit 1da50b8 into main Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants