fix: connected deferred exit parent span with original entry span #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhilash-sivan
approved these changes
Sep 27, 2024
|
pre-approving |
aryamohanan
reviewed
Sep 27, 2024
kirrg001
commented
Sep 27, 2024
| @@ -20,7 +20,7 @@ const express = require('express'); | |||
| const fetch = require('node-fetch-v2'); | |||
| const NATS = require('nats'); | |||
|
|
|||
| const log = require('@instana/core/test/test_util/log').getLogger('NATS Subscriber'); | |||
| const log = require('@instana/core/test/test_util/log').getLogger('NATS Subscriber: '); | |||
There was a problem hiding this comment.
The log output was broken.
kirrg001
commented
Sep 27, 2024
| : expect(span.p).to.equal(natsEntry.s), | ||
| span => expect(span.k).to.equal(constants.EXIT) | ||
| version === 'latest' | ||
| ? expect(span.t).to.equal(httpEntrySpan.t) |
There was a problem hiding this comment.
We are now able to connect the correct trace.
kirrg001
changed the title
aryamohanan
reviewed
Sep 27, 2024
| @@ -689,7 +724,8 @@ function verifyHttpExit({ | |||
| withClientError, | |||
| withServerError, | |||
| withTimeout, | |||
| serverControls | |||
| serverControls, | |||
| params = null | |||
There was a problem hiding this comment.
I added another optional check.
If the test passes params, we test params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on #1297
Problem: the deferred http request was not traced correctly. It was not connected to the entry http server span.