Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added otel instrumentation for tedious #1030

Merged
merged 9 commits into from
Feb 15, 2024
Merged

feat: added otel instrumentation for tedious #1030

merged 9 commits into from
Feb 15, 2024

Conversation

aryamohanan
Copy link
Contributor

@aryamohanan aryamohanan commented Feb 9, 2024

As part of Azure SQL integration, we've chosen to improve support for the tedious library through the implementation of opentelemetry-tedious. We've also conducted tests to verify its compatibility with Azure Database.

Currently, our support extends to tedious version 15.1.3, due to limitations with the otel instrumentation.

@aryamohanan aryamohanan requested a review from a team as a code owner February 9, 2024 08:41
@aryamohanan aryamohanan marked this pull request as draft February 9, 2024 08:41
@aryamohanan aryamohanan marked this pull request as ready for review February 13, 2024 09:39
@aryamohanan aryamohanan marked this pull request as draft February 13, 2024 14:41
@aryamohanan aryamohanan marked this pull request as ready for review February 14, 2024 04:41
@aryamohanan aryamohanan force-pushed the tedious branch 3 times, most recently from d355dc5 to d776861 Compare February 14, 2024 11:25
Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Feel free to merge this when the JSON file is resolved :)

@aryamohanan aryamohanan merged commit 87de73d into main Feb 15, 2024
1 of 2 checks passed
@aryamohanan aryamohanan deleted the tedious branch February 15, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants