Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No newline at eol in formatted notebooks #37

Closed
weery opened this issue Feb 10, 2023 · 1 comment
Closed

No newline at eol in formatted notebooks #37

weery opened this issue Feb 10, 2023 · 1 comment

Comments

@weery
Copy link
Contributor

weery commented Feb 10, 2023

We use the new black formatting in databricks notebooks which adds a newline at the end of each notebook. We also use blackbricks in our CI/CD pipeline to check for formatting issues. To make sure that our CI/CD passes we tend to checkout our changes locally just to run blackbricks locally before we run our pipeline, which is quite tedious.

A potential fix #36

@weery
Copy link
Contributor Author

weery commented Feb 10, 2023

Another way of handling this while keeping backwards compability would be to add a CLI option defaulting to current master, see #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant