Add support for some HTML Input attributes

[hugooliveirad]

It would be very useful if newforms Field API supported some HTML attributes such as placeholder and disabled. There's any reason this isn't implemented?

[insin]

I have plans for disabled and hidden, as they affect validation/requiredness and skipping rendering. Eventually, I want to have a way to define rules for those to implement dynamic show/hide/enable/disable.

placeholder is purely about display, though. How about a new core Field property - widgetAttrs - which lets you provide additional attributes for the field's widget without having to completely override it? This could be what's returned by the base Field.prototype.widgetAttrs() instead of the current hardcoded empty object.

[hugooliveirad]

Yes, widgetAttrs property looks like a great way to do that. Having to completely override the widget to do such a simple thing like adding placeholder ou class is way too complex.

What attrs would we support? This object is merged with NumberField.prototype.widgetAttrs()? (Couldn't analyze the code enough).

Adding this would make it possible to add data- attributes too, although I couldn't find any use case for them inside React.

[insin]

It would support any attribute you care to pass 😄

Fields add any widget attributes they're going to provide here:

newforms/src/Field.js

Line 59 in 7c25efb

object.extend(widget.attrs, this.widgetAttrs(widget))

Then any attributes provided during rendering, or passed into BoundField when rendering are merged over the top of them here:

newforms/src/Widget.js

Line 55 in 7c25efb

return object.extend({}, this.attrs, renderAttrs, kwargAttrs)

This new core field property could also be the basis for allowing people to attach their own event handlers when creating istances of forms, for not much extra work... this could be a more interesting next release than I thought 👍

[hugooliveirad]

So we could simply add

kwargs.widgetAttrs = kwargs.widgetAttrs || {};
object.extend(kwargs.widgetAttrs, widget.attrs, this.widgetAttrs(widget));

?

[hugooliveirad]

Awesome 👍