Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Deprecated Functions #1386

Closed
donyunardi opened this issue Oct 16, 2024 · 3 comments · Fixed by #1406
Closed

Review Deprecated Functions #1386

donyunardi opened this issue Oct 16, 2024 · 3 comments · Fixed by #1406
Assignees
Labels
core good first issue Good for newcomers

Comments

@donyunardi
Copy link
Contributor

donyunardi commented Oct 16, 2024

Summary

Let's review the functions we deprecated in the previous release and decide whether to hard deprecate them (lifecycle::deprecate_stop) or remove them from the codebase entirely.

Function Action
hard deprecate on TealData Remove
datasets argument in ui and srv formals in module() Remove
@donyunardi donyunardi changed the title Review Deprecate functions Review Deprecated Functions Oct 16, 2024
@donyunardi donyunardi added the good first issue Good for newcomers label Oct 16, 2024
@m7pr
Copy link
Contributor

m7pr commented Nov 13, 2024

Hey @donyunardi and @llrs-roche the same question as in teal.slice insightsengineering/teal.slice#623 (comment)

Should we revisit lifecycle::badge("experimental") and lifecycle::badge("stable")

@llrs-roche
Copy link
Contributor

llrs-roche commented Nov 13, 2024

There are 7 experimental features and 10 stable:

  • Experimental:
    • Functions: 6
    • Argument: 1
  • stable:
    • Functions: 10
    • Argument: 0

Also 2 deprecated and 1 superseded function.

@donyunardi
Copy link
Contributor Author

Please see my response in:
insightsengineering/teal.slice#623 (comment)

I propose handling the badge updates separately so we can ensure a consistent update across all teal packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants