Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Implement a teal_transform_module #1228

Closed
gogonzo opened this issue May 22, 2024 · 1 comment · Fixed by #1260
Closed

[Feature Request]: Implement a teal_transform_module #1228

gogonzo opened this issue May 22, 2024 · 1 comment · Fixed by #1260
Assignees
@averissimo
Labels
core enhancement New feature or request
Milestone
teal transform

Comments

@gogonzo
Copy link
Contributor

gogonzo commented May 22, 2024 •
edited
Loading

Feature description

See this file where most of the work is done.

  • teal_transform_module's ui and server should be consumed in ui/srv_nested_tabs just after creation of teal_data object.
  • Beware that instead of data (teal_data), datasets (FilteredData) object could be still used in a module, and transform can't be performed on FilteredData. Please include transform under condition is_arg_used(modules$server, "data")
  • Add validates for reactive teal_data find here
@gogonzo gogonzo added the enhancement New feature or request label May 22, 2024
@gogonzo gogonzo added this to the teal transform milestone May 22, 2024
@gogonzo gogonzo mentioned this issue May 22, 2024
Closed
@averissimo averissimo self-assigned this Jul 2, 2024
@averissimo averissimo mentioned this issue Jul 5, 2024
Merged
@averissimo averissimo linked a pull request Jul 5, 2024 that will close this issue
Implement teal_transform_module #1260
Merged
@donyunardi
Copy link
Contributor

Can we close this? @averissimo @gogonzo

@gogonzo gogonzo mentioned this issue Aug 12, 2024
Merged
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@averissimo averissimo

Labels
core enhancement New feature or request
Projects
None yet
Milestone
teal transform
Development

Successfully merging a pull request may close this issue.

Implement teal_transform_module insightsengineering/teal
3 participants
@averissimo @gogonzo @donyunardi