Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Make a new data-summary #1226

Closed
gogonzo opened this issue May 21, 2024 · 3 comments · Fixed by #1257
Closed

[Feature Request]: Make a new data-summary #1226

gogonzo opened this issue May 21, 2024 · 3 comments · Fixed by #1257
Assignees
Labels
core enhancement New feature or request

Comments

@gogonzo
Copy link
Contributor

gogonzo commented May 21, 2024

Blocked by #1229

  1. Module should produce the same table as FilteredData$ui_overview.
    • arguments: id, data (reactive teal_data)
    • output: reactive teal_data
  2. Module's server should be called just before passing data to the teal_module (look here)
  3. Beware that instead of data (teal_data), datasets (FilteredData) object could be still used in a module, and transform can't be performed on FilteredData. Please include summary under condition is_arg_used(modules$server, "data")
  4. Module's ui should be included in a relevant place to inform how data have changed in a "transformation".

Hide existing filter-panel-summary so we don't need to make changes in teal.slice. Please keep in mind this issue

@gogonzo gogonzo added the enhancement New feature or request label May 21, 2024
@gogonzo gogonzo added this to the teal transform milestone May 21, 2024
@gogonzo gogonzo changed the title [Feature Request]: Make a new data-rows-summary [Feature Request]: Make a new data-summary May 21, 2024
@kumamiao
Copy link
Contributor

Prefers to have it within the module (and collapsable if possible) instead of a separate tab

@gogonzo
Copy link
Contributor Author

gogonzo commented May 23, 2024

Prefers to have it within the module (and collapsable if possible) instead of a separate tab

What do you mean specifically?
If you want this in the teal_module, then it will be in the encoding panel, and it will be something which module-developer will have to add (call the summary-module inside of own teal_module).

Current idea is that summary will be inserted in the sidebar where filter-panel is and where teal_transform will be. Every item in this sidebar will be collapsible.

@kumamiao kumamiao added the core label Jun 6, 2024
@m7pr m7pr self-assigned this Jul 2, 2024
@m7pr
Copy link
Contributor

m7pr commented Jul 2, 2024

@gogonzo just double checking we want this to be a feature implemented in teal based on a feature we had in teal.slice?

@gogonzo gogonzo linked a pull request Jul 5, 2024 that will close this issue
1 task
@gogonzo gogonzo closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants