Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ID coupling #1160

Open
donyunardi opened this issue Mar 15, 2024 · 0 comments
Open

Avoid ID coupling #1160

donyunardi opened this issue Mar 15, 2024 · 0 comments
Labels

Comments

@donyunardi
Copy link
Contributor

donyunardi commented Mar 15, 2024

This introduces a coupling to the ids defined in teal.reporter. If we ever change it for some reason - teal would have to be re-released. The same goes with teal.slice and other packages. I would like to avoid this and keep releases as much independent as possible.
This actually happened in the past - on teal.slice refactor we broke tests in teal.modules.hermes just because they were written like this.
Please invest in finding a good way to avoid such coupling.

Originally posted by @pawelru in #1127 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant