keep_titles, etc not respected when selecting zero rows via [

[gmbecker]

keep_titles works (and, I imagine, the other rtables specific args to [) if we select at least one row, but not if we select zero rows:

lyt <- basic_table(title = "hiya I'm a title!") %>%
    split_rows_by("ARM") %>%
    analyze("AGE")

tbl <- build_table(lyt, ex_adsl)

> main_title(tbl[1, , keep_titles = TRUE])
[1] "hiya I'm a title!"
> main_title(tbl[integer(), , keep_titles = TRUE])
[1] ""

[gmbecker]

@shajoezhu any movement about this

[shajoezhu]

ah, sorry, missed this thread. would the expected results be "hiya I'm a title!"? or should this throw an error, as we could treat tbl[integer(), , keep_titles = TRUE] as an empty table? null table?

@BFalquet @Melkiades @edelarua any thoughts?

I think we should have "hiya I'm a title!", as if we prune or trim a table, and as the results, it has zero rows, title and footnotes, these should return values. right? if this is the case, this is a bug, and we can take care of this. Thanks

[Melkiades]

I would keep all decorators, even if it is a 0-rows table

[edelarua]

I would keep all decorators as well.

[gmbecker]

The code should do whatever the arguments say (e.g. keep_titles = TRUE vs FALSE). There are times when the title, top-left, etc is no longer appropriate when subsetting rows, and there are times when it is.

My point is that I told it to keep titles and it didn't, which is a bug.

[shajoezhu]

all agreed. its a bug