From c686adfcd417b5f37e880414c1fd7da80c1a6f1c Mon Sep 17 00:00:00 2001
From: Emily de la Rua <emily.de_la_rua@contractors.roche.com>
Date: Tue, 14 Nov 2023 14:47:49 -0500
Subject: [PATCH] Add option to remove cell spaces (to print in viewer), update
 docs

---
 R/as_html.R    | 12 ++++++++++--
 man/as_html.Rd |  9 +++++++--
 2 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/R/as_html.R b/R/as_html.R
index dd8b140f0..f97118d7a 100644
--- a/R/as_html.R
+++ b/R/as_html.R
@@ -27,12 +27,15 @@ div_helper <- function(lst, class) {
 #' @param class_table class for `table` tag
 #' @param class_tr class for `tr` tag
 #' @param class_th class for `th` tag
-#' @param width width
+#' @param width a string to indicate the desired width of the table. Common input formats include a 
+#'   percentage of the viewer window width (e.g. `"100%"`) or a distance value (e.g. `"300px"`). 
+#'   Defaults to `NULL`.
 #' @param link_label link anchor label (not including `tab:` prefix) for the table.
 #' @param bold elements in table output that should be bold. Options are `"main_title"`, `"subtitles"`,
 #'   `"header"`, `"row_names"`, `"label_rows"`, and `"content_rows"` (which includes any non-label rows).
 #'   Defaults to `"header"`.
 #' @param header_sep_line whether a black line should be printed to under the table header. Defaults to `TRUE`.
+#' @param no_spaces_between_cells whether spaces between table cells should be collapsed. Defaults to `FALSE`.
 #'
 #' @return A `shiny.tag` object representing `x` in HTML.
 #'
@@ -65,7 +68,8 @@ as_html <- function(x,
                     class_th = NULL,
                     link_label = NULL,
                     bold = c("header"),
-                    header_sep_line = TRUE) {
+                    header_sep_line = TRUE,
+                    no_spaces_between_cells = FALSE) {
   if (is.null(x)) {
     return(tags$p("Empty Table"))
   }
@@ -218,6 +222,10 @@ as_html <- function(x,
       rows,
       list(
         class = class_table,
+        style = paste(
+          if (no_spaces_between_cells) "border-collapse: collapse;", 
+          if (!is.null(width)) paste("width:", width)
+        ),
         tags$caption(sprintf("(\\#tag:%s)", link_label),
           style = "caption-side: top;",
           .noWS = "after-begin"
diff --git a/man/as_html.Rd b/man/as_html.Rd
index 63e035a6a..91d99d208 100644
--- a/man/as_html.Rd
+++ b/man/as_html.Rd
@@ -12,13 +12,16 @@ as_html(
   class_th = NULL,
   link_label = NULL,
   bold = c("header"),
-  header_sep_line = TRUE
+  header_sep_line = TRUE,
+  no_spaces_between_cells = FALSE
 )
 }
 \arguments{
 \item{x}{\code{rtable} object}
 
-\item{width}{width}
+\item{width}{a string to indicate the desired width of the table. Common input formats include a
+percentage of the viewer window width (e.g. \code{"100\%"}) or a distance value (e.g. \code{"300px"}).
+Defaults to \code{NULL}.}
 
 \item{class_table}{class for \code{table} tag}
 
@@ -33,6 +36,8 @@ as_html(
 Defaults to \code{"header"}.}
 
 \item{header_sep_line}{whether a black line should be printed to under the table header. Defaults to \code{TRUE}.}
+
+\item{no_spaces_between_cells}{whether spaces between table cells should be collapsed. Defaults to \code{FALSE}.}
 }
 \value{
 A \code{shiny.tag} object representing \code{x} in HTML.