Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section name lab_name: Name is confusing #114

Open
discoleo opened this issue Mar 2, 2023 · 1 comment
Open

Section name lab_name: Name is confusing #114

discoleo opened this issue Mar 2, 2023 · 1 comment
Labels
question Further information is requested sme Tracks changes for the sme board

Comments

@discoleo
Copy link

discoleo commented Mar 2, 2023

Section: lab_name

The name of this section can be confusing: clinical trials can involve labs. Some R functions may contain the argument "lab", but it is not associated with "name".

Solution

Name could be changed to "label_name" or "lbl_name" or "name.lbl":

  • the "label" keyword is already used for some functions;
  • "lbl" is shorter, while less likely to be confused;
  • name.lbl or names.lbl: can benefit from the tools available for generic functions in R;

Note:

  • generic functions can be easily searched in R using the methods function:

names.lbl = function(x) print(x); # just some test
methods(names)
# [1] names.lbl names.POSIXlt

@discoleo discoleo added the enhancement New feature or request label Mar 2, 2023
@Melkiades Melkiades added the question Further information is requested label Mar 14, 2023
@Melkiades
Copy link
Contributor

Melkiades commented Mar 14, 2023

@gmbecker do you think we can change this w/o affecting the API too much? I am not sure of this. It could be a candidate for an alias eventually

@Melkiades Melkiades added sme Tracks changes for the sme board and removed enhancement New feature or request labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested sme Tracks changes for the sme board
Projects
None yet
Development

No branches or pull requests

2 participants