Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip: Improve stories titles for ShowOnTruncation feature. #2444

Open
satyamyadav opened this issue Dec 5, 2024 · 3 comments
Open

Tooltip: Improve stories titles for ShowOnTruncation feature. #2444

satyamyadav opened this issue Dec 5, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@satyamyadav
Copy link
Collaborator

Description

Update the story titles according to the following mappings:

  • Auto Tooltip >> Show on Truncation story
  • Show Tooltip >> Custom Trigger story
  • Auto Tooltip on Hook >> Custom Trigger ( Hook ) story

Steps to reproduce

Run the storybook locally and navigate to Tooltip.

Expected result

Story titles should be more contextual.

Actual result

Story titles are technical only.

@satyamyadav satyamyadav added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 5, 2024
@nidhi-wa
Copy link
Contributor

nidhi-wa commented Jan 1, 2025

@satyamyadav I'd like to take on this issue.

@nidhi-wa
Copy link
Contributor

nidhi-wa commented Jan 1, 2025

Hi @satyamyadav , I've created a PR and would appreciate if you can follow up my work. Thanks!

@satyamyadav
Copy link
Collaborator Author

@nidhi-wa I have approved your github actions run so you can now check the changes live from the pull request.
Screenshot 2025-01-02 at 11 52 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants