From 7c141ae9bce1e1f140e9647680176e7f3a65ea81 Mon Sep 17 00:00:00 2001 From: beer-1 Date: Mon, 3 Mar 2025 21:29:08 +0900 Subject: [PATCH] return error ack when the packet is wasm routed but has error at decoding --- app/ibc-hooks/receive.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/ibc-hooks/receive.go b/app/ibc-hooks/receive.go index 0acc825..5aa8e98 100644 --- a/app/ibc-hooks/receive.go +++ b/app/ibc-hooks/receive.go @@ -27,7 +27,7 @@ func (h WasmHooks) onRecvIcs20Packet( data transfertypes.FungibleTokenPacketData, ) ibcexported.Acknowledgement { isWasmRouted, hookData, err := validateAndParseMemo(data.GetMemo()) - if !isWasmRouted || hookData.Message == nil { + if !isWasmRouted || (err == nil && hookData.Message == nil) { return im.App.OnRecvPacket(ctx, packet, relayer) } else if err != nil { return newEmitErrorAcknowledgement(err) @@ -91,7 +91,7 @@ func (h WasmHooks) onRecvIcs721Packet( data nfttransfertypes.NonFungibleTokenPacketData, ) ibcexported.Acknowledgement { isWasmRouted, hookData, err := validateAndParseMemo(data.GetMemo()) - if !isWasmRouted || hookData.Message == nil { + if !isWasmRouted || (err == nil && hookData.Message == nil) { return im.App.OnRecvPacket(ctx, packet, relayer) } else if err != nil { return newEmitErrorAcknowledgement(err)