Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tendermint config optional values parsing #906

Closed
tzemanovic opened this issue Jun 16, 2021 · 0 comments · Fixed by #908
Closed

Tendermint config optional values parsing #906

tzemanovic opened this issue Jun 16, 2021 · 0 comments · Fixed by #908
Labels
bug Something isn't working

Comments

@tzemanovic
Copy link
Contributor

The Tendermint config parser from toml uses a custom serde deserializing function for optional config values deserialize_optional_value, which requires an empty string when there's no value. If the optional field is missing from the config altogether, it fails with e.g.:

"missing field tls_cert_file for key rpc at line 96 column 1"

This could be relaxed as the Tendermint node does accept missing optional fields.

Furthermore, the serialization for the config omits the fields with optional values when there's no value, so it cannot parse back what it has written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant