You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a couple problems with the serialization (or rather, deserialization) implemented in #676 which prevents existing consensus state JSON files from being read. (Note: we can support a new serialization, it's just the deserialization that needs to be backwards compatible)
null block_id field
tendermint_proto::serializers::optional does not appear to handle the field being explicitly null, e.g.:
invalid type: null, expected struct BlockId at line 1 column 50
total field of parts::Header
This was previously serialized as a string. It now appears to be serialized as an integer. This causes the following error when deserializing an existing file:
invalid type: string "1", expected u32 at line 1 column 146
The text was updated successfully, but these errors were encountered:
The total field was changed in Tendermint Go too. I can write a compatibility layer to be able to deserialize from string OR int, but we should keep in mind that serialization will follow the new normal.
This means that KMS can upgrade from an older version but cannot downgrade after a new version was executed.
There are a couple problems with the serialization (or rather, deserialization) implemented in #676 which prevents existing consensus state JSON files from being read. (Note: we can support a new serialization, it's just the deserialization that needs to be backwards compatible)
null
block_id
fieldtendermint_proto::serializers::optional
does not appear to handle the field being explicitlynull
, e.g.:This results in the following error:
total
field ofparts::Header
This was previously serialized as a string. It now appears to be serialized as an integer. This causes the following error when deserializing an existing file:
The text was updated successfully, but these errors were encountered: