Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light-node: Re-enable test commented out because of cargo bug surfaced in WASM PR #560

Closed
romac opened this issue Sep 9, 2020 · 1 comment

Comments

@romac
Copy link
Member

romac commented Sep 9, 2020

In the WASM PR (#553), I had to disable the only previously enabled acceptance test of the light node CLI for the test suite to pass (7c07134).

Without this commit, cargo test --all-features --no-fail-fast would fail with:

       Doc-tests tendermint-light-client
    error[E0460]: found possibly newer version of crate `tendermint` which `tendermint_rpc` depends on
     --> /Users/coromac/Informal/Code/Current/tendermint-rs/light-client/src/components/io.rs:7:5
      |
    7 | use tendermint_rpc as rpc;
      |     ^^^^^^^^^^^^^^
      |
      = note: perhaps that crate needs to be recompiled?
      = note: the following crate versions were found:
              crate `tendermint`: /Users/coromac/Informal/Code/Current/tendermint-rs/target/debug/deps/libtendermint.rlib
              crate `tendermint`: /Users/coromac/Informal/Code/Current/tendermint-rs/target/debug/deps/libtendermint-735716e8d731096d.rmeta
              crate `tendermint_rpc`: /Users/coromac/Informal/Code/Current/tendermint-rs/target/debug/deps/libtendermint_rpc-ad41c355acf2752f.rlib

    error: aborting due to previous error

It is currently unclear why this error has appeared, though I suspect it is a bug in Cargo related to features flags (which we now use to disable non WASM-compatible code).

The likely reason for why disabling this test resolves the issue above, is that there is no more a need to rebuild the light node crate to run the light node binary with cargo run. It's not clear why rebuilding the crate is necessary when running cargo run as part of the test (when everything should have been compiled already, though perhaps not with the same flags) but I suspect that doing so in the middle of running (doc)tests is causing the issue.

@ebuchman ebuchman added this to the v0.18 milestone Sep 11, 2020
@thanethomson thanethomson removed this from the v0.19 milestone Apr 7, 2021
@thanethomson
Copy link
Contributor

Seems like this may no longer be relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants