New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tendermint: revisit pub_key module #443

Open

liamsi opened this issue Jul 13, 2020 · 0 comments

Labels

crypto structure

Member

liamsi commented Jul 13, 2020 •

edited

Loading

It would be better if the (now) optional parts of tendermint/src/public_key.rs were broken out into separate files
(see https://github.com/informalsystems/tendermint-rs/pull/441/files#r453714311). Also it's worth having a closer look into the existing unreachable statements: https://github.com/informalsystems/tendermint-rs/pull/441/files#r453764087
also #441 (review)

tendermint-rs/tendermint/src/config/node_key.rs

Lines 50 to 54 in 1218256

    
               pub fn node_id(&self) -> node::Id { 
        
                   #[allow(unreachable_patterns)] 
        
                   match &self.public_key() { 
        
                       PublicKey::Ed25519(key) => node::Id::from(*key), 
        
                       _ => unreachable!(),

The text was updated successfully, but these errors were encountered:

ebuchman added the structure label

xla changed the title ~~Revisit pub_key module~~ tendermint: revisit pub_key module

ebuchman added the crypto label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment