Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light client errors follow-up #154

Closed
3 tasks done
liamsi opened this issue Feb 12, 2020 · 2 comments · Fixed by #155
Closed
3 tasks done

Light client errors follow-up #154

liamsi opened this issue Feb 12, 2020 · 2 comments · Fixed by #155

Comments

@liamsi
Copy link
Member

liamsi commented Feb 12, 2020 •
edited
Loading

@liamsi
Copy link
Member Author

liamsi commented Feb 12, 2020 •
edited
Loading

make sure we return Error everywhere and not Kind (#149 (comment))

As far as I can tell, all methods use an Error in their Result. So nothing to do here really. Unless I misunderstood the comment. A few returns where changed in #151.

@liamsi liamsi mentioned this issue Feb 12, 2020
Merged
5 tasks
@liamsi
Copy link
Member Author

liamsi commented Feb 12, 2020

All addressed in #155

@liamsi liamsi mentioned this issue Feb 12, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Followup on 149 and 151 informalsystems/tendermint-rs
1 participant
@liamsi