Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not generate tendermint-proto from source with buf dependencies #1289

Closed
mzabaluev opened this issue Apr 3, 2023 · 2 comments · Fixed by #1293
Closed

Can not generate tendermint-proto from source with buf dependencies #1289

mzabaluev opened this issue Apr 3, 2023 · 2 comments · Fixed by #1293
Labels
enhancement New feature or request

Comments

@mzabaluev
Copy link
Contributor

Description

Originally reported as cometbft/cometbft#565

tendermint-proto-compiler needs to be able to process buf dependencies in the buf.lock file in order to fetch third-party
protobuf modules used by CometBFT proto module source in releases starting from 0.37.0.
For #1193 I have scrounged by generating off the v0.37.0-alpha.1 release and checking that the proto source has not changed between then and the eventual 0.37.x releases, but to adapt to any future changes we need to adapt to the buf way of managing protobuf dependencies.

Definition of "done"

The tool that's used to generate code for tendermint-proto (either t-p-compiler or, if you feel ambitious, switch completely to buf.build) can deal with the buf dependencies in CometBFT releases since v0.37.0.

@mzabaluev mzabaluev added the enhancement New feature or request label Apr 3, 2023
@tony-iqlusion
Copy link
Collaborator

We're dealing with a similar issue on cosmos-rust: cosmos/cosmos-rust#318

So far we modified our proto-build to shell out to buf, however protoc-gen-prost looks promising: https://github.com/neoeinstein/protoc-gen-prost

@mzabaluev
Copy link
Contributor Author

mzabaluev commented Apr 5, 2023

I'm implementing it as a shell-out as well, to have a tendermint-proto-compiler that can work with older v0.34.x checkouts as well as v0.37.x and later revisions in the CometBFT repository.

We will switch to full-on buf for generation and transition to using versioned cometbft protos as a source at a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants