Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Clear up or ignore unused .jar files when upgrading modelator. #147

Closed
danwt opened this issue Dec 7, 2021 · 3 comments · Fixed by #151
Closed

[BUG] Clear up or ignore unused .jar files when upgrading modelator. #147

danwt opened this issue Dec 7, 2021 · 3 comments · Fixed by #151
Labels
bug Something isn't working

Comments

@danwt
Copy link
Contributor

danwt commented Dec 7, 2021

Description

The user upgrades the version of modelator but does not delete old .jars or the old .modelator directory. This causes the newer modelator to find the old jars (which be the wrong versions) and fail.

Expected behavior

Modelator should detect old jars and replace them with the correct ones.

@danwt danwt added the bug Something isn't working label Dec 7, 2021
@danwt
Copy link
Contributor Author

danwt commented Dec 7, 2021

I suggest we allocate this feature to mbt-python, as mbt-python will in the future take care of all jars/downloads.

@danwt danwt changed the title [FEATURE] Clear up or ignore unused .jar files when upgrading modelator. [BUG] Clear up or ignore unused .jar files when upgrading modelator. Dec 7, 2021
@rnbguy
Copy link
Member

rnbguy commented Dec 7, 2021

I agree @danwt. but we have to fix the bug for usability. I will open a PR to fix this in Rust for next patch release.

@danwt
Copy link
Contributor Author

danwt commented Dec 7, 2021

I agree @danwt. but we have to fix the bug for usability. I will open a PR to fix this in Rust for next patch release.

Yep, good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants