Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove has route #740

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Remove has route #740

merged 2 commits into from
Jul 5, 2023

Conversation

PanGan21
Copy link
Contributor

@PanGan21 PanGan21 commented Jul 1, 2023

Closes: #503

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@PanGan21 PanGan21 mentioned this pull request Jul 1, 2023
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate @PanGan21 your contribution. This works 🙏

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (1c5b50b) 72.33% compared to head (ba834bc) 72.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
- Coverage   72.33%   72.32%   -0.01%     
==========================================
  Files         116      116              
  Lines       15529    15510      -19     
==========================================
- Hits        11233    11218      -15     
+ Misses       4296     4292       -4     
Impacted Files Coverage Δ
crates/ibc/src/core/handler.rs 90.14% <ø> (+1.53%) ⬆️
crates/ibc/src/core/router.rs 81.19% <ø> (ø)
crates/ibc/src/mock/context.rs 73.84% <ø> (-0.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@plafer plafer merged commit 6249d46 into informalsystems:main Jul 5, 2023
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* remove has route and refactor validate and execute functions

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Router::has_route
3 participants