Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Header trait under mocks #715

Closed
plafer opened this issue Jun 13, 2023 · 2 comments
Closed

Move Header trait under mocks #715

plafer opened this issue Jun 13, 2023 · 2 comments
Labels
O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding O: usability Objective: aims to enhance user experience (UX) and streamline product usability

Comments

@plafer
Copy link
Contributor

plafer commented Jun 13, 2023

Currently, the Header trait is only used in tests. Hence, we should move it somewhere under the mocks module.
@plafer plafer added O: usability Objective: aims to enhance user experience (UX) and streamline product usability O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding labels Jun 13, 2023
@plafer plafer added this to ibc-rs Jun 13, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Jun 13, 2023
@Farhad-Shabani
Copy link
Member

Does it differ from #617 ?

@plafer
Copy link
Contributor Author

plafer commented Jun 14, 2023

Hmm, no not really. I'm not sure if it's better to remove or move to tests only, but we can figure it out when we work on the issue. Closing

@plafer plafer closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plafer @Farhad-Shabani