Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update standalone query functions to use the specified query_height #1155

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

Farhad-Shabani
Copy link
Member

Closes: #1154


PR author checklist:

  • Added changelog entry, using unclog.
  • Linked to GitHub issue.
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani changed the title fix: update standalone query functions to use the specified query _height fix: update standalone query functions to use the specified query_height Apr 4, 2024
@Farhad-Shabani Farhad-Shabani added this to the 0.52.0 milestone Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 63.91%. Comparing base (2b9de34) to head (fa7ddf4).

Files Patch % Lines
ibc-query/src/core/channel/query.rs 0.00% 40 Missing ⚠️
ibc-query/src/core/connection/query.rs 0.00% 20 Missing ⚠️
ibc-query/src/core/client/query.rs 0.00% 10 Missing ⚠️
ibc-query/src/core/connection/types/request.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
- Coverage   63.98%   63.91%   -0.08%     
==========================================
  Files         219      219              
  Lines       21313    21338      +25     
==========================================
  Hits        13638    13638              
- Misses       7675     7700      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani requested a review from rnbguy April 8, 2024 13:16
Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! ✨ LGTM ✔️

@Farhad-Shabani Farhad-Shabani added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 91bee67 Apr 8, 2024
16 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/consider-query-height-in-query-funcs branch April 8, 2024 16:01
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
…ight` (#1155)

* fix: use query_height in query functions

* chore: add changelog

* nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standalone query functions disregard query_height
2 participants