Refactor interrupts plugin code #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall I like this, only thing I wouldn't do is move the file reading into parseInterrupts. It's generally a good idea to keep IO separate from logic in case to make testing easier. |
|
@danielnelson ok hopefully I won't be asking you to review this plugin code again anytime soon :). I moved the IO outside of |
calerogers
force-pushed
the
update-interrupts-plugin
branch
2 times, most recently
from
103340e to
4ea2d14
Compare
calerogers
force-pushed
the
update-interrupts-plugin
branch
from
4ea2d14 to
17a4536
Compare
vlamug
pushed a commit
to vlamug/telegraf
that referenced
this pull request
May 30, 2017
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
@danielnelson Sorry for the noise and this extra PR, but I was making some updates to the interrupts plugin's code before I noticed you merged in the previous one (thanks btw!). I think this refactor cleans up the code rather nicely if you'd like to take a look and merge it in, of course it isn't urgent. Feel free to close the PR if you don't think it's necessary. thanks again!