Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulnerabilities in packages Telegraf depends on (Telegraf 1.18.2) #9225

Closed
vishiy opened this issue Apr 30, 2021 · 6 comments
Closed

vulnerabilities in packages Telegraf depends on (Telegraf 1.18.2) #9225

vishiy opened this issue Apr 30, 2021 · 6 comments
Labels
security raise security concerns or improve the security of Telegraf

Comments

@vishiy
Copy link
Contributor

vishiy commented Apr 30, 2021

Please see the below CVEs with HIGH severity

image

Expected : No CVEs. Please upgrade to later packages (see FIXED version in the image above for the go packages)

@vishiy vishiy added the bug unexpected problem or unintended behavior label Apr 30, 2021
@ssoroka ssoroka changed the title HIGH SEVERITY VULNERABILITIES IN LATEST TELEGRAF (1.18.2) vulnerabilities in packages Telegraf depends on (Telegraf 1.18.2) Apr 30, 2021
@ssoroka ssoroka added security raise security concerns or improve the security of Telegraf and removed bug unexpected problem or unintended behavior labels Apr 30, 2021
@helenosheaa
Copy link
Member

Thanks for opening the issue!

I just checked Telegraf 1.18.2 and we are on github.com/dgrijalva/jwt-go/v4, this is the pr that fixed it from Telegraf 1.16.2 onwards.

Also this pr updates apache/thrift to v0.13.0 and updates hashicorp/consul to v1.6.0 which should be included in 1.19.0.

There is an existing issue also about upgrading to higher than v1.6.0 for hashicorp.

@vishiy
Copy link
Contributor Author

vishiy commented Apr 30, 2021

Thank you @helenosheaa . if jwt-go was fixed in 1.16.2, why is it flagged for 1.18.2 ? Do you know ? Are you saying this is false positive ?
Hoping to see all fixes in 1.19.0.

Sorry @ssoroka , i didn't realize the title was in all caps :(

@helenosheaa
Copy link
Member

I'm not sure why it's flagging it, the only place I can see v3.2.0+incompatible is in our go.sum but our go.mod only has the version v4.0.0-preview1 with the fix in it and thats the only one we are importing into our packages.

I'll link on here when the pr with the fix for the other ones gets released.

@reimda
Copy link
Contributor

reimda commented May 5, 2021

@vishiy Would you rescan now that 9238 is merged? If you need binaries for the scan you could the PR CI build (#9238 (comment)) or the next nightly.

@vishiy
Copy link
Contributor Author

vishiy commented Jun 9, 2021

@reimda thanks. I tried with the last release (1.18.3). Below are the vulnerabilties i see on the dependencies .

image

@powersj
Copy link
Contributor

powersj commented Oct 25, 2021

@vishiy,

I think the github.com/tidwall/gjson issues are fixed, as I see version v1.9.0 or newer currently on master.
For github.com/apache/thrift I also see us using v0.15.0 on master.

I am going to go ahead and close this.

We do have a security policy for notifying of potential CVEs. Please do use the email and steps in our SECURITY.md document.

Thanks!

@powersj powersj closed this as completed Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security raise security concerns or improve the security of Telegraf
Projects
None yet
Development

No branches or pull requests

5 participants