Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sql Server - remove tag "database_name" is some collectors #7724

Closed
Trovalo opened this issue Jun 24, 2020 · 2 comments
Closed

Sql Server - remove tag "database_name" is some collectors #7724

Trovalo opened this issue Jun 24, 2020 · 2 comments
Labels
area/sqlserver feature request Requests for new plugin and for new features to existing plugins

Comments

@Trovalo
Copy link
Collaborator

Trovalo commented Jun 24, 2020

Feature Request

In most collectors the "database_name" tag is useless (at least when obtained using DB_NAME() ), since the queries are instance wide and do not use a database scope, so in general it will just return a fixed value, probably "master".

Those are the queries in which the tag looks useless to me.

  • PerformanceCounters
  • WaitStatsCategorized
  • ServerProperties
  • MemoryClerk
  • Schedulers
  • SqlRequests (here the useful tag is called "session_db_name")

Proposal:

Remove the tag "database_name" when not useful

@denzilribeiro
Copy link
Contributor

denzilribeiro commented Jun 24, 2020

This was added primarily for the Azure SQL DB case as a logical server isn't a n instance in Azure and there is no way to correlate DB's otherwise. Once we split things up per # 7713 will be much easier to remove for on-prem. Right now some of the collectors are shared. This is also one of the reasons to split things else would have to have conditional if/else logic for engine edition/type in every collector which makes no sense.

@danielnelson danielnelson added area/sqlserver feature request Requests for new plugin and for new features to existing plugins labels Jun 26, 2020
@Trovalo
Copy link
Collaborator Author

Trovalo commented Oct 27, 2020

THis has been done in the query splitting and also in the later query refactoring

@Trovalo Trovalo closed this as completed Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sqlserver feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

No branches or pull requests

3 participants