Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"newShard()" needs to be used throughout code #2455

Closed
otoolep opened this issue Apr 29, 2015 · 2 comments
Closed

"newShard()" needs to be used throughout code #2455

otoolep opened this issue Apr 29, 2015 · 2 comments
Labels
internal kind/refactor
Milestone
0.9.2

Comments

@otoolep
Copy link
Contributor

otoolep commented Apr 29, 2015

There are multiple places in our code where shard creation (and restoration of shard metadata) is not consistent, leaving some pointers nil under certain circumstances. This has caused multiple issues, and needs to be fixed, most likely through some refactoring.
@otoolep
Copy link
Contributor Author

otoolep commented Apr 29, 2015

CC @corylanou

@otoolep otoolep mentioned this issue Apr 29, 2015
Merged
@beckettsean beckettsean added this to the 0.9.0 milestone Apr 30, 2015
@toddboom toddboom modified the milestones: 0.9.0, 0.9.1 May 8, 2015
@toddboom toddboom modified the milestones: 0.9.1, 0.9.2 Jun 5, 2015
@otoolep
Copy link
Contributor Author

otoolep commented Jun 23, 2015

No longer applicable in new design.

@otoolep otoolep closed this as completed Jun 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal kind/refactor
Projects
None yet
Milestone
0.9.2
Development

No branches or pull requests
4 participants
@toddboom @otoolep @corylanou @beckettsean