From 04c060cf0ccfebe159a23a9c1311865379264a17 Mon Sep 17 00:00:00 2001 From: Ximin Luo Date: Wed, 14 Mar 2018 15:50:09 +0100 Subject: [PATCH] Fix a bug in #5152 that causes rustc/rustdoc to fail unnecessarily --- src/bin/commands/rustc.rs | 3 ++- src/bin/commands/rustdoc.rs | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/bin/commands/rustc.rs b/src/bin/commands/rustc.rs index ea4c71b6183..6dfe416381d 100644 --- a/src/bin/commands/rustc.rs +++ b/src/bin/commands/rustc.rs @@ -62,7 +62,8 @@ pub fn exec(config: &mut Config, args: &ArgMatches) -> CliResult { let mut compile_opts = args.compile_options_for_single_package( config, mode, )?; - compile_opts.target_rustc_args = Some(values(args, "args")); + let target_args = values(args, "args"); + compile_opts.target_rustc_args = if target_args.is_empty() { None } else { Some(target_args) }; ops::compile(&ws, &compile_opts)?; Ok(()) } diff --git a/src/bin/commands/rustdoc.rs b/src/bin/commands/rustdoc.rs index 60cb4d24c91..3a1cdd69125 100644 --- a/src/bin/commands/rustdoc.rs +++ b/src/bin/commands/rustdoc.rs @@ -45,7 +45,8 @@ pub fn exec(config: &mut Config, args: &ArgMatches) -> CliResult { let mut compile_opts = args.compile_options_for_single_package( config, CompileMode::Doc { deps: false }, )?; - compile_opts.target_rustdoc_args = Some(values(args, "args")); + let target_args = values(args, "args"); + compile_opts.target_rustdoc_args = if target_args.is_empty() { None } else { Some(target_args) }; let doc_opts = DocOptions { open_result: args.is_present("open"), compile_opts,