Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to keyed lists break FLIP animations when they occur mid-animation #1519

Closed
dead-claudia opened this issue Jul 19, 2020 · 3 comments
Closed

Comments

@dead-claudia
Copy link

dead-claudia commented Jul 19, 2020

Before submitting an issue please:

  • Check that you are using the latest version of Inferno. Either using our CDN @ Master or by checking the tags on NPM.
  • Check that the bug has not been fixed in the latest development version. Use our CDN @ Edge.
  • Check that the issue has not been brought up before on Github issues.

If you can, please distill your problem down and include a JSFiddle example for illustration. Also when requesting bug fix please include at least one test to avoid regression.

Inferno version: 7.4.2

Steps to reproduce:

  1. Open this Flems link

Expected: The animation to be smooth like in this near-identical vanilla version

Actual: The animation is choppy.

Edit: Inferno is far from the only one affected https://twitter.com/isiahmeadows1/status/1284726730574315522

Also relevant: https://github.com/whatwg/html/issues/5742

@Havunen
Copy link
Member

Havunen commented Sep 15, 2021

Is this something what new inferno animation package will solve @jhsware ?

@jhsware
Copy link
Contributor

jhsware commented Sep 15, 2021

Yes @Havunen, this should be solved by inferno-animation. The Shuffle w. Anim test in inferno/docs/animations-demo/index.html doesn't shuffle the keys (it shuffles the items) but it should be equivalent behaviour.

@jhsware
Copy link
Contributor

jhsware commented Oct 22, 2021

@Havunen this is fixed as of https://github.com/infernojs/inferno/releases/tag/v8.0.0-alpha.0

@Havunen Havunen closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants