Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan for Gun v2? #193

Closed
phunehehe opened this issue Sep 24, 2022 · 4 comments
Closed

Any plan for Gun v2? #193

phunehehe opened this issue Sep 24, 2022 · 4 comments

Comments

@phunehehe
Copy link
Collaborator

phunehehe commented Sep 24, 2022

Hi!

I happened to hack up some support for shotgun in a project that needs gun v2 (the timeline for release is unclear but the RC has been out for a while now). The only problem that I see is transport_opts has been split into tcp_opts and tls_opts. With the following patch it works fine for my use: master...phunehehe:shotgun:gun2.

I figure it might be too early to actually incorporate changes like this into shotgun, but just in case there is interest in a gun2 branch, I hope it helps.

Thanks,
Phu

@elbrujohalcon
Copy link
Member

Hi @phunehehe. Thanks for the contribution. We're not actively maintaining or using this project that much lately. So, if others like you would like to use gun2's RC, I'm fine with merging a PR with those changes.

@phunehehe
Copy link
Collaborator Author

@elbrujohalcon awesome \o/ I made a PR #194

@phunehehe
Copy link
Collaborator Author

Hi again @elbrujohalcon!
It turned out Gun 2.0.0 has been released, so I have updated the PR to use that instead of the RC.

@elbrujohalcon
Copy link
Member

You're now an official maintainer, @phunehehe … Feel free to create a new release of the project if you need to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants