add ExcludedPeople #252
Closed
add ExcludedPeople #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JW-CH
requested changes
Jan 10, 2025
| @@ -38,6 +38,18 @@ private Task<IEnumerable<Guid>> ExcludedAlbumAssets | |||
| } | |||
| } | |||
|
|
|||
| private Task<IEnumerable<Guid>>? _excludedPeopleAssets; | |||
| private Task<IEnumerable<Guid>> ExcludedPeopleAssets | |||
There was a problem hiding this comment.
Why do you query for all assets of a person when an asset has the information already, if a Person (People) exist on there?
|
|
||
| randomAssets = randomAssets.Where(x => !excludedList.Contains(Guid.Parse(x.Id))).ToList(); | ||
| randomAssets = randomAssets.Where(x => !excludedAlbumList.Contains(Guid.Parse(x.Id)) && !excludedPeopleList.Contains(Guid.Parse(x.Id))).ToList(); |
There was a problem hiding this comment.
you could access x.People here and have access to a list of person contained on that asset. We might have a Problem when x.People is null because it was not delivered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #248