Metadata Search: Option 'isOffline' is ignored

[Salvoxia]

The bug

The API Documentation for the searchMetadata endpoint specifies a search option isOffline.
My expectation is that this option can be used to find all assets that are currently marked as offline.
However, that option seems to be ignored entirely, yielding the same search results as if no search options were supplied.

I believe this option is simply forgotten in searchAssetBuilder function of the database utils.

The OS that Immich Server is running on

Debian 12 Bookworm

Version of Immich Server

v1.117.0

Version of Immich Mobile App

does not apply

Platform with the issue

• Server
• Web
• Mobile

Your docker-compose.yml content

Does not apply

Your .env content

Does not apply

Reproduction steps

1. Have an external library with at least one offline and one online asset in your Immich database
2. Run the following cURL command

curl -L 'https://immich.mydomain.com/api/search/metadata' \
-H 'Content-Type: application/json' \
-H 'Accept: application/json' \
-H 'x-api-key: myapikey' \
-d '{
  "isOffline": true
}'

2. The results contain assets with isOffline: false
3. The results are identical to running the following command without any search options

curl -L 'https://immich.mydomain.com/api/search/metadata' \
-H 'Content-Type: application/json' \
-H 'Accept: application/json' \
-H 'x-api-key: myapikey' \
-d '{}'

Relevant log output

No response

Additional information

No response

[Salvoxia]

Following up on this. At the moment (v1.121.0) the metadata search seems to no longer include offline assets at all, nor does it include trashed assets (rendering the trashedAfter and trashedBefore filters useless).
My use case is to automate removal of offline assets, but only offline assets, not the entire trash.
The only way to get these assets at the moment seems using the timeline with isTrashed=true, but that seems to me abusing that API endpoint for something it was not built for.