Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest plain text #1417

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Ingest plain text #1417

merged 4 commits into from
Dec 18, 2023

Conversation

imartinez
Copy link
Collaborator

Add a new API to ingest plain text.

  • Deprecate previous /ingest API
  • Move previous ingestion logic to a new ingest/file API
  • Create a new ingest/text API that allows for plain text ingestion by passing the file_name and the plain text to be ingested. A single Document is generated for the ingested text.

All the previously existing ingestion logic is reused to leverage the different ingestion capabilities. A little refactor is done in IngestService to accommodate the new text ingestion

Screenshot 2023-12-17 at 22 13 08

@imartinez imartinez requested a review from lopagela December 17, 2023 21:14
Copy link
Contributor

Copy link
Contributor

@imartinez imartinez requested a review from pabloogc December 18, 2023 16:29
Copy link
Collaborator

@pabloogc pabloogc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@imartinez imartinez merged commit 6eeb95e into main Dec 18, 2023
8 checks passed
@imartinez imartinez deleted the feature/ingest-text branch December 18, 2023 20:47
simonbermudez pushed a commit to simonbermudez/saimon that referenced this pull request Feb 24, 2024
* Add ingest/text route to ingest plain text

* Add new ingest text test and adapt ingest/file ones

* Include new API in docs

* Remove duplicated logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants