Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve delphes #84

Merged
merged 8 commits into from
Jun 25, 2020
Merged

Improve delphes #84

merged 8 commits into from
Jun 25, 2020

Conversation

gaede
Copy link
Contributor

@gaede gaede commented Jun 24, 2020

BEGINRELEASENOTES

  • improve the delphes2lcio tool
    • add configuration options for LCIO collection names and delphes branches to be used
    • the default configuration works for the ILD delphes card https://github.com/ILDAnaSoft/ILDDelphes
    • it can be overwritten with a simple configuration file see ./examples/delphes2lcio.cfg and Advanced Topics in the READM.md
    • additional jet collections can be added to the event if available in the delphes output
      - current default are Durham2Jets-Durham6Jets

ENDRELEASENOTES

@gaede
Copy link
Contributor Author

gaede commented Jun 25, 2020

CI status report still hangs - builds finished successfully.

@gaede gaede merged commit a54d8a9 into iLCSoft:master Jun 25, 2020
@andresailer
Copy link
Contributor

andresailer commented Jun 25, 2020

(@gaede @rete)
I can't see the details on the checks for this PR but I think the problem is
in (settings -> branches -> Branch protection rules -> edit)
https://github.com/iLCSoft/LCIO/settings/branch_protection_rules/15481203

image

instead of

image

Edit: details under View Details for the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants