-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up a CI run with AddressSanitizer #802
Comments
@Antonov548: Can you please take this on? We can use the Docker image at https://github.com/wch/r-debug to avoid building R from scratch. We still need to install igraph dependencies in the Docker image. I propose to set up a CI/CD workflow that builds a Docker image based on
This is a bit terse, can you work with that? Happy to clarify as needed. |
Thanks @krlmlr and @Antonov548 ! This will be very useful. |
For the third step, we could use a Docker action: https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action . If we do this, the first step modifies the entrypoint of the Docker image. |
Everything can live in this repository. See, e.g., https://github.com/tidyverse/tibble/tree/main/.github/workflows/check for an action that is embedded in the repo, and https://github.com/tidyverse/tibble/blob/main/.github/workflows/R-CMD-check.yaml#L72 for usage. |
Done now, we'll improve as we go. |
This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary. |
There should be an AddressSanitizer-enabled CI run. This will provide some extra confidence while migrating to igraph 0.10, and it will make it much easier to debug crash bugs.
This will require building R itself with AddressSanitizer first, and caching the R installation. After this, igraph can be installed as normal, as R itself will pass the correct flags.
This is how I do this now locally: https://github.com/igraph/igraph/wiki/Using-sanitizers-to-find-bugs#rigraph
@krlmlr Can you help with this?
The text was updated successfully, but these errors were encountered: