Scale light intensity by PI for Ogre2 #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
ahcorde
approved these changes
Mar 26, 2021
chapulina
added
beta
Codecov Report
@@ Coverage Diff @@
## main #284 +/- ##
=======================================
Coverage 57.54% 57.54%
=======================================
Files 159 159
Lines 15590 15590
=======================================
Hits 8971 8971
Misses 6619 6619
Continue to review full report at Codecov.
|
iche033
pushed a commit
that referenced
this pull request
Apr 27, 2021
Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Ian Chen <[email protected]>
iche033
added a commit
that referenced
this pull request
Apr 28, 2021
Signed-off-by: Ian Chen <[email protected]> fix! Signed-off-by: Ian Chen <[email protected]> Scale intensity by PI for Ogre2 (#284) Signed-off-by: Addisu Z. Taddese <[email protected]> Update particles tutorial gif (#288) * update tutorial pic Signed-off-by: Ian Chen <[email protected]> * update gif Signed-off-by: Ian Chen <[email protected]> Update simple demo gif (#287) Signed-off-by: Ian Chen <[email protected]> Update README for version 5 (#286) Signed-off-by: Ian Chen <[email protected]> Bump main to 6.0.0~pre1 (#297) Signed-off-by: Louise Poubel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The light intensity has to be scaled by PI before applying it as the power scale for Ogre2 lights. Without this change, the default sun light brightness is different between ign-gazebo4 and ign-gazebo5
Left: ign-gazebo4, Right: ign-gazebo5
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge