Pimpl'ize ogre2 classes #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 52.03% 52.04% +0.01%
==========================================
Files 143 143
Lines 13095 13100 +5
==========================================
+ Hits 6814 6818 +4
- Misses 6281 6282 +1
Continue to review full report at Codecov.
|
chapulina
approved these changes
Sep 14, 2020
| /// brief Pointer to the Gaussian noise ogre material | ||
| private: Ogre::Material *gaussianNoiseMat = nullptr; | ||
| /// \brief Pointer to private data class | ||
| private: std::unique_ptr<Ogre2GaussianNoisePassPrivate> dataPtr; |
There was a problem hiding this comment.
I didn't see a warning, but there's no include memory.
Signed-off-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated several ogre2 classes to use pimpl. Most of the private classes are currently empty.
Signed-off-by: Ian Chen [email protected]