Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing validator.keyring-backend from config.yml #3129

Closed
fadeev opened this issue Nov 18, 2022 · 0 comments · Fixed by #3190
Closed

Consider removing validator.keyring-backend from config.yml #3129

fadeev opened this issue Nov 18, 2022 · 0 comments · Fixed by #3190
Assignees
@jeronimoalbi
Labels
proposal

Comments

@fadeev
Copy link
Contributor

fadeev commented Nov 18, 2022 •
edited
Loading

cli/ignite/chainconfig/v1/validator.go

Line 28 in 36974ff

KeyringBackend string `yaml:"keyring-backend,omitempty"`

Keyring backend can be configured though the validator's client option, it seems redundant so it might be an issue from in the config refactor. See chain.go.

Currently, we have validator.keyring-backend and validator.client.keying-backend. Both serve the same purpose and we should probably remove validator.keyring-backend.

Context: #3042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeronimoalbi jeronimoalbi

Labels
proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove redundant keyring-backend option ignite/cli
2 participants
@fadeev @jeronimoalbi