Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the scaffold band command and remove info about Bandchain from the docs #2887

Closed
fadeev opened this issue Oct 6, 2022 · 4 comments · Fixed by #2993
Closed

Hide the scaffold band command and remove info about Bandchain from the docs #2887

fadeev opened this issue Oct 6, 2022 · 4 comments · Fixed by #2993
Assignees
Labels

Comments

@fadeev
Copy link
Contributor

fadeev commented Oct 6, 2022

It's not maintained and we need to move this functionality into a plugin: #3928

We don't have to delete the code, just hide temporarily until we're ready to move it to a plugin and make an arrangement with Band for them to maintain it.

@fadeev fadeev added the proposal label Oct 6, 2022
@tbruyelle
Copy link
Contributor

It's a good first real usage of the plugins! Should we create a new ignite repo for the plugins ?

@aljo242
Copy link
Contributor

aljo242 commented Oct 7, 2022

It's a good first real usage of the plugins! Should we create a new ignite repo for the plugins ?

I think this is a great idea. @ilgooz wdyt?

@aljo242
Copy link
Contributor

aljo242 commented Oct 7, 2022

This could be the first plugin we include in an ignite/plugins repo

@fadeev
Copy link
Contributor Author

fadeev commented Oct 9, 2022

I think one of the advantages of the plugin system is that other entities would be maintaining some of them. I think with Band that should be the case. It's a chain-specific functionality and if they want it in the CLI, they should assign a dev to maintain it.

Having plugins in a single repo I think is perfectly fine. Codeowners file can be used to specify who is responsible for which plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants