Bug when specifying protocol in host.* in config.yml

[fadeev]

host:
  api: "http://192.168.1.208:1317"
  rpc: "http://192.168.1.208:26657"

Results in tcp://http://192.168.1.208:1317 in config.toml.

We may need to revisit the host property. Currently, we have:

RPC:      "0.0.0.0:26657",
P2P:      "0.0.0.0:26656",
Prof:     "0.0.0.0:6060",
GRPC:     "0.0.0.0:9090",
API:      "0.0.0.0:1317",
Frontend: "0.0.0.0:8080",
DevUI:    "0.0.0.0:12345",

RPC, P2P, prof, gRPC, and API can be configure through init.config and init.app. Frontend and Dev UI are no longer relevant. I'm wondering whether we need the host property. We can keep it, of course, but there is still confusion when users try to set init.app.api.address and it doesn't get set in app.toml, because we overwrite it with our default.

[andynog]

Removing the http:// seems to work

host:
  api: "192.168.1.208:1317"
  rpc: "192.168.1.208:26657"

[jeronimoalbi]

Config format changed since this issue was created, Cosmos app and Tendermint settings are configured using the validators config options. Each validator has the app and config map properties.
Just tested the config using the described values and verified that the config.toml and app.toml files are generated correctly.

@salmad3 I think we can close this issue.