Skip to content

Fix returning null in TimeBasedWeatherValueData #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
johanneshiry opened this issue May 21, 2021 · 0 comments · May be fixed by #1302
Open

Fix returning null in TimeBasedWeatherValueData #356

johanneshiry opened this issue May 21, 2021 · 0 comments · May be fixed by #1302
Assignees
@pierrepetersmeier
Labels
bug Something isn't working

Comments

@johanneshiry
Copy link
Member

johanneshiry commented May 21, 2021 •
edited
Loading

TimeBasedWeatherValueData:36 returns null instead of e.g. Optional. This is dangerous as it might cause NullPointerExceptions and hence should be addressed.

This also affects the corresponding interface method and may require more refactoring.
@johanneshiry johanneshiry added the bug Something isn't working label May 21, 2021
@pierrepetersmeier pierrepetersmeier self-assigned this Mar 3, 2024
@pierrepetersmeier pierrepetersmeier mentioned this issue Mar 18, 2024
Closed
pierrepetersmeier added a commit that referenced this issue Mar 21, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#356-fix-returning-null-in-timebasedweathe…
a77123c 
…rvaluedata
danielfeismann added a commit that referenced this issue Jun 12, 2024
@danielfeismann
Merge branch 'refs/heads/dev' into pp/#356-fix-returning-null-in-time…
f4c99c5 
…basedweathervaluedata
pierrepetersmeier added a commit that referenced this issue Jun 13, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#356-fix-returning-null-in-timebasedweathe…
5d7a35c 
…rvaluedata
pierrepetersmeier added a commit that referenced this issue Mar 18, 2025
@pierrepetersmeier
Merge branch 'dev' into pp/#356-fix-returning-null-in-timebasedweathe…
5fd17a3 
…rvaluedata
@pierrepetersmeier pierrepetersmeier linked a pull request Apr 11, 2025 that will close this issue
Fix returning null in TimeBasedWeatherValueData.java #1302
Draft
@pierrepetersmeier pierrepetersmeier linked a pull request Apr 11, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierrepetersmeier pierrepetersmeier

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@johanneshiry @pierrepetersmeier